Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fixed workflow for generating introspection query for docs #578

Merged
merged 7 commits into from
May 6, 2024
Merged

ci: fixed workflow for generating introspection query for docs #578

merged 7 commits into from
May 6, 2024

Conversation

banasa44
Copy link
Contributor

@banasa44 banasa44 commented Apr 24, 2024 •
edited
Loading

Description

In this PR two problems are fixed:

  1. We have now 2 processes that generate 2 different types of introspection-query for subgraph schema. Some modifications need to be done for the introspection for docs purposes. Create a temp schema, add some necessary lines for the introspection-partial, generate it, and delete the temp.schema.

https://subgraph.satsuma-prod.com/aragon/osx-carles-sepolia/version/2/playground

Task ID: OS-1221

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

josemarinas
josemarinas previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@josemarinas josemarinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@banasa44 banasa44 force-pushed the fix/subgraph-docs-processes branch from ffc642b to 0240476 Compare April 25, 2024 09:29
Rekard0
Rekard0 reviewed Apr 26, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
Rekard0
Rekard0 reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you deploy subgraph and provide QA url?
look at checkbox:
I have updated the Subgraph and added a QA URL to the description of this PR.

@banasa44 @Rekard0
Update .gitignore
b3e7e09 
Co-authored-by: Rekard0 <[email protected]>
heueristik
heueristik previously approved these changes Apr 30, 2024
View reviewed changes
.github/workflows/subgraph-documentation-update.yml Outdated Show resolved Hide resolved
@heueristik heueristik changed the title Fix: Subgraph docs processes fix: subgraph docs processes Apr 30, 2024
heueristik
heueristik previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a PR title that follows https://www.conventionalcommits.org/en/v1.0.0/
The PR titles will be visible in our release page by customers (see, for example, https://github.com/aragon/osx/releases/tag/v1.3.0).

@banasa44 banasa44 changed the title fix: subgraph docs processes ci: fixed workflow for generating introspection query for docs Apr 30, 2024
@jordaniza jordaniza marked this pull request as draft May 3, 2024 09:59
@banasa44 banasa44 marked this pull request as ready for review May 3, 2024 13:15
@banasa44 banasa44 requested a review from heueristik May 3, 2024 13:15
Rekard0
Rekard0 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@banasa44 banasa44 merged commit c92d129 into develop May 6, 2024
16 checks passed
@banasa44 banasa44 deleted the fix/subgraph-docs-processes branch May 6, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@josemarinas josemarinas josemarinas approved these changes

@heueristik heueristik Awaiting requested review from heueristik

Assignees
No one assigned
Labels
subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@banasa44 @Rekard0 @heueristik @josemarinas